Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: Sharing header files -- arch/arm/mach-generic ? | Date | Mon, 23 Apr 2012 20:15:41 +0000 |
| |
On Monday 23 April 2012, Pavel Machek wrote: > I have new architecture I'd like to merge into the mainline. It has > some code very similar to existing plaforms (for example > real differences to mach-realview/platsmp.c are two lines.) > > Is that a problem? > > Should mach-generic/platsmp.c be created, so code can be better > shared? Or are the code pieces small enough that this duplication can > be ignored?
Hi Pavel,
I'd suggest you just post the code with the duplicate files for review at first, and then we can discuss what to do with them. As Russell mentioned, the code might not actually be ideal in the duplicate version so you end up rewriting it, or there might be a different solution that someone finds when we see the patches.
Arnd
| |