Messages in this thread | | | Date | Mon, 23 Apr 2012 17:39:59 +0200 | From | Juri Lelli <> | Subject | Re: [PATCH 05/16] sched: SCHED_DEADLINE policy implementation. |
| |
On 04/23/2012 04:35 PM, Peter Zijlstra wrote: > On Fri, 2012-04-06 at 09:14 +0200, Juri Lelli wrote: >> +static void init_dl_task_timer(struct sched_dl_entity *dl_se) >> +{ >> + struct hrtimer *timer =&dl_se->dl_timer; >> + >> + if (hrtimer_active(timer)) { >> + hrtimer_try_to_cancel(timer); >> + return; >> + } > > Same question I guess, how can it be active here? Also, just letting it > run doesn't seem like the best way out.. >
Probably s/hrtimer_try_to_cancel/hrtimer_cancel is better.
>> + >> + hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); >> + timer->function = dl_task_timer; >> + timer->irqsafe = 1; >> +}
Thanks,
- Juri
| |