Messages in this thread | | | Date | Mon, 23 Apr 2012 13:57:24 +0200 | From | Juri Lelli <> | Subject | Re: [PATCH 05/16] sched: SCHED_DEADLINE policy implementation. |
| |
On 04/23/2012 01:34 PM, Peter Zijlstra wrote: > On Fri, 2012-04-06 at 09:14 +0200, Juri Lelli wrote: >> + /* >> + * At this point, the deadline really should be "in >> + * the future" with respect to rq->clock. If it's >> + * not, we are, for some reason, lagging too much! >> + * Anyway, after having warn userspace abut that, >> + * we still try to keep the things running by >> + * resetting the deadline and the budget of the >> + * entity. >> + */ >> + if (dl_time_before(dl_se->deadline, rq->clock)) { >> + WARN_ON_ONCE(1); > > Doing printk() and friends from scheduler context isn't actually safe > and can lock up your machine.. there's a printk_sched() that > maybe-sorta-kinda can get your complaints out.. >
Thanks! I'll look at it.
>> + dl_se->deadline = rq->clock + dl_se->dl_deadline; >> + dl_se->runtime = dl_se->dl_runtime; >> + }
- Juri
| |