Messages in this thread | | | Date | Mon, 23 Apr 2012 14:19:25 +0400 | From | Kinsbursky Stanislav <> | Subject | Re: [CRIU] [PATCH v2 0/2] IPC: message queue checkpoint/restore - requested updates |
| |
Hello, Andrew. I'm very sorry, but a critical flaw has been found in this feature: copying of kernel data to user is done under spinlock. Since message queue size can be increased up to INT_MAX, then copying to temporary kernel buffer while passing message queue in not a solution. So, please, drop both patches (feature implementation and test). Most probably Ill replace them with MSG_PEEK feature (the same logic, but only for one message - like it's done for sockets).
-- Best regards, Stanislav Kinsbursky
| |