Messages in this thread Patch in this message | | | From | Shreshtha Kumar SAHU <> | Date | Fri, 20 Apr 2012 09:28:46 +0200 | Subject | RE: [PATCH 1/2] leds-lm3530: comment correction about the range of brightness |
| |
I feel driver should take care of range provided by hardware by scaling the value provided by user, instead of limiting the max brightness to user.
For .e.g. here it can be something like this - err = i2c_smbus_write_byte_data(drvdata->client, LM3530_BRT_CTRL_REG, brt_val / 2);
I am not sure if application really use/check max brightness in before calculating/setting new brightness values.
-----Original Message----- From: Kim, Milo [mailto:Milo.Kim@ti.com] Sent: Thursday, April 19, 2012 12:11 PM To: Andrew Morton Cc: Shreshtha Kumar SAHU; linus.walleij@linaro.org; Richard Purdie; linux-kernel@vger.kernel.org Subject: [PATCH 1/2] leds-lm3530: comment correction about the range of brightness
max brightness is 127, so the range of brt_val should be from 0 to 127
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com> --- include/linux/led-lm3530.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/led-lm3530.h b/include/linux/led-lm3530.h index eeae6e7..4b13347 100644 --- a/include/linux/led-lm3530.h +++ b/include/linux/led-lm3530.h @@ -92,7 +92,7 @@ struct lm3530_pwm_data { * @als2_resistor_sel: internal resistance from ALS2 input to ground * @als_vmin: als input voltage calibrated for max brightness in mV * @als_vmax: als input voltage calibrated for min brightness in mV - * @brt_val: brightness value (0-255) + * @brt_val: brightness value (0-127) * @pwm_data: PWM control functions (only valid when the mode is PWM) */ struct lm3530_platform_data { -- 1.7.4.1
Best Regards, Milo (Woogyom) Kim
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |