Messages in this thread | | | Date | Fri, 20 Apr 2012 23:55:22 +0530 | Subject | Re: [PATCH] regulator: Provide a check for dummy regulator | From | Jassi Brar <> |
| |
On 20 April 2012 20:12, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > >> > No. You're failing to understand what dummy regulators are for. > >> I think I do understand what dummy regulators are for and also that >> they are meant to go away some time in future. > > No, they're here to stay - people will always be bringing up new boards > after all - but they're not supposed to be used on platforms. > "some time in future" means utopia.... whenever that be. The longer that is to more important is it for dummy support to be 'complete'.
> > In any case, as I've said it's not the fact that you've got a dummy > supply that's an issue for most of the cases you mention - it's the fact > that the supply is always on. > I am not sure anymore you read my posts :( I am more bothered by the case where the supply is always off i.e, physically absent.
> Even in the case where a supply might genuinely be missing (which are > very unusual, it's more effort in silicon to cope with missing supplies) > It's not that unusual. See vcc_aux at line 150 of omap_hsmmc.c
See how dummy fools the driver throughout into stuff like toggling vcc even for platforms that don't really provide vcc_aux. In practice, see how dummy affects (negatively because of unnecessary toggles) the vcc too. Not every platform with omap_hsmmc might afford having dummy disabled (I don't know all to tell for sure).
Best Regards, -Jassi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |