lkml.org 
[lkml]   [2012]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v2 15/21] loop: use aio to perform io on the underlying file
On 04/20/2012 07:57 PM, Dave Kleikamp wrote:
>> So yeah, I'd agree that the loop code should be reworked a bit so that
>> both the filebacked and aio methods call vfs_sync() when they see
>> REQ_FLUSH.
> It's an easy fix. I don't anticipate that it will hurt performance too
> badly.

Two questions:

1. Could we use fdatasync there? (otherwise it can hurt performance very
badly)

2. vfs_sync() is synchronous. loop_thread() will be blocked till it's
completed. Would it be better to perform vfs_sync in another thread (to
allow other bio-s in loop queue proceed)? Also, if there are more than
one REQ_FLUSH bio in lo->lo_bio_list, we could call vfs_sync() only
once. Make sense?

Thanks,
Maxim


\
 
 \ /
  Last update: 2012-04-20 18:17    [W:0.365 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site