Messages in this thread | | | From | Mike Frysinger <> | Subject | Re: [PATCH] blackfin: fix ifdef fustercluck in mach-bf538/boards/ezkit.c | Date | Fri, 20 Apr 2012 00:08:34 -0400 |
| |
On Wednesday 18 April 2012 23:57:18 Paul Gortmaker wrote: > This file has lots and lots of ifdef, around structure decls > and structure usages.
yeah. we killed some off, and there probably is room for more, but some of the subsystems are not friendly to dynamic resource management, so we need some of the ifdefs. SPI doesn't like it if you declare resources for different devices on the same CS even if you never actually use the device in question. be nice if the detection could be delayed until "open" time.
> but since I had to tag the #endif with their respective #ifdef > options to find this misplaced SPI endif, it would be silly to > then go and delete them all. So they stay.
Acked-by: Mike Frysinger <vapier@gentoo.org> -mike [unhandled content-type:application/pgp-signature] | |