lkml.org 
[lkml]   [2012]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] ACPI: D3 states cleanup
From
Date
On Fri, 2012-04-20 at 13:23 +0800, Aaron Lu wrote:
> On Fri, Apr 20, 2012 at 11:19:13AM +0800, Lin Ming wrote:
> > On Fri, 2012-04-20 at 10:23 +0800, Aaron Lu wrote:
> > > Hi,
> > >
> > > On Fri, Apr 20, 2012 at 09:19:09AM +0800, Lin Ming wrote:
> > > > There are two ACPI D3 states defined now:
> > > > ACPI_STATE_D3 and ACPI_STATE_D3_COLD.
> > > >
> > > > But the uses of these states are not clear/correct in some code.
> > > > For example, some code refer ACPI_STATE_D3 as D3hot and others refer
> > > > it as D3cold.
> > > >
> > > > This patch introduces ACPI_STATE_D3_HOT to refer to ACPI D3hot state.
> > > > And changes ACPI_STATE_D3 to refer to ACPI D3cold state only.
> > > > Also redefines ACPI_STATE_D3_COLD the same as ACPI_STATE_D3.
> > > >
> > >
> > > With this patch now, if a device has _PS3, then we will set its D3hot
> > > flag valid. This doesn't feel right to me, since per our discussion the
> > > other day, we should assume _PS3 will put the device into D3cold.
> > >
> > > Or do you mean: if _PS3 is available, then both D3hot and D3cold is
> > > valid from the perspective of acpi, it is the individual driver's
> > > responsibility to decide which state is actually valid and will be used.
> >
> > Right.
> >
> > ACPI_STATE_D3(same as ACPI_STATE_D3_COLD now) is always valid.
> >
>
> I mean, if _PS3 is available, can we say D3hot is valid?

Yes.

Lin Ming



\
 
 \ /
  Last update: 2012-04-20 07:39    [W:1.580 / U:1.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site