lkml.org 
[lkml]   [2012]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] spi/spi-ep93xx.c: use dma_transfer_direction instead of dma_data_direction
From
Date
On Thu, 2012-04-19 at 09:10 +0300, Mika Westerberg wrote:
> On Tue, Apr 17, 2012 at 06:46:36PM -0700, H Hartley Sweeten wrote:
> > A new enum indicating the dma channel direction was introduced by:
> >
> > commit 49920bc66984a512f4bcc7735a61642cd0e4d6f2
> > dmaengine: add new enum dma_transfer_direction
> >
> > The following commit changed spi-ep93xx to use the new enum:
> >
> > commit a485df4b4404379786c4bdd258bc528b2617449d
> > spi, serial: move to dma_transfer_direction
> >
> > In doing so a sparse warning was introduced:
> >
> > warning: mixing different enum types
> > int enum dma_data_direction versus
> > int enum dma_transfer_direction
> >
> > This is produced because the 'dir' passed in ep93xx_spi_dma_prepare
> > is an enum dma_data_direction and is being used to set the
> > dma_slave_config 'direction' which is now an enum dma_transfer_direction.
> >
> > Fix this by converting spi-ep93xx to use the new enum type in all
> > places.
> >
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> > Cc: Grant Likely <grant.likely@secretlab.ca>
> > Cc: Vinod Koul <vinod.koul@linux.intel.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@iki.fi>
Acked-by: Vinod Koul <vinod.koul@intel.com>

--
~Vinod



\
 
 \ /
  Last update: 2012-04-20 12:15    [W:1.601 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site