Messages in this thread | | | Date | Mon, 2 Apr 2012 15:11:25 -0400 | From | Paul Gortmaker <> | Subject | Re: [PATCH 03/11] avr32: fix nop compile fails from system.h split up |
| |
On 12-04-02 01:47 AM, David Howells wrote: > Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > >> To fix: >> >> In file included from kernel/exit.c:61: >> arch/avr32/include/asm/mmu_context.h: In function 'enable_mmu': >> arch/avr32/include/asm/mmu_context.h:135: error: implicit >> declaration of function 'nop' > > Better would be to move the definition of nop() into asm/barrier.h to be > consistent with other arches.
That does seem to make sense. But just to confirm, then I'd end up deleting the new file, arch/avr32/include/asm/special_insns.h
------------ commit ae473946586680b01c13975a3b674de23ad7c93e Author: David Howells <dhowells@redhat.com> Date: Wed Mar 28 18:30:01 2012 +0100
Disintegrate asm/system.h for AVR32 Disintegrate asm/system.h for AVR32. This has not been compiled at all. Signed-off-by: David Howells <dhowells@redhat.com> cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
:000000 100644 0000000... f922218... A arch/avr32/include/asm/special_insns.h ------------
...since it only contains the nop definition.
Is that what you had in mind, or is some other content going to be moved there at a later time?
Thanks, Paul.
> > David
| |