Messages in this thread | | | Date | Thu, 19 Apr 2012 15:17:46 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] init: fix bug where environment vars can't be passed via boot args |
| |
On Fri, 6 Apr 2012 12:53:50 -0400 Chris Metcalf <cmetcalf@tilera.com> wrote:
> Commit 026cee0086f had the side-effect of dropping the '=' from > the unknown boot arguments that are passed to init as environment > variables. This is because parse_args() puts a NUL in the string > where the '=' was when it passes the "param" and "val" pointers > to the parsing subfunctions. Previously, unknown_bootoption() was > the last parse_args() subfunction to run, and it carefully put back > the '=' character. Now ignore_unknown_bootoption() is the last > one to run, and it wasn't doing the necessary repair, so the > envp params ended up with the embedded NUL and were no longer > seen as valid environment variables by init.
This patch has been stuck in your tree for a week or two. The copy there is missing Woody's Tested-by and (I suspect) his Reported-by and Pawel's Acked-by.
And because that patch is already in linux-next, I can't (or rather don't want to) merge it myself.
It needs to be merged into 3.4. Please fix up the changelog data and send it in?
| |