Messages in this thread | | | Date | Thu, 19 Apr 2012 16:44:44 -0400 | From | Jarod Wilson <> | Subject | Re: [PATCH 1/1] [media] ite-cir: postpone ISR registration |
| |
On Wed, Apr 18, 2012 at 09:54:07PM +0100, Luis Henriques wrote: > An early registration of an ISR was causing a crash to several users (for > example here: http://bugs.launchpad.net/bugs/972723 The reason was that > IRQs were being triggered before the driver initialisation was completed. > > This patch fixes this by moving the invocation to request_irq() to a later > stage on the driver probe function.
Ugh. Looks like we actually have a similar problem with multiple lpc super i/o based CIR drivers. I'd probably move both the irq and io region requests in ite-cir, fintek-cir, nuvoton-cir, ene_ir and winbond-cir. If I'm thinking clearly, I've actually seen a very similar report for one of the other CIR drivers recently. Good catch. But yeah, lets do the same for all the drivers, and move request_region as well.
-- Jarod Wilson jarod@redhat.com
| |