Messages in this thread | | | Date | Thu, 19 Apr 2012 16:00:23 -0400 | From | Konrad Rzeszutek Wilk <> | Subject | Re: [Xen-devel] [PATCH 2/2] xen: implement IRQ_WORK_VECTOR handler |
| |
> >> +static irqreturn_t xen_irq_work_interrupt(int irq, void *dev_id) > >> +{ > >> + irq_enter(); > >> + inc_irq_stat(apic_irq_work_irqs); > >> + irq_work_run(); > > > > I think this usually done the other way around: > > > > irq_work_run() > > inc_irq_stat(apic_irq_work_irqs) > > > > Or is there an excellent reason for doing it this way? > > Copy & paste from smp_irq_work_interrupt(). > But I think there is no much difference. > > Anyway, I can change it if needed.
Please do. It looks at odds with the other usages in this file. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |