Messages in this thread | | | Date | Thu, 19 Apr 2012 22:08:20 +0300 | From | Mika Westerberg <> | Subject | Re: [PATCH v2] smb347_charger: Cleanup power supply registration code in probe |
| |
On Thu, Apr 19, 2012 at 10:00:18AM +0530, Ramakrishna Pallala wrote: > This patch checks if the usb or mains charging is enabled by the > platform before registering with the power supply class.
I still don't like the idea of having the power-supplies registered conditionally. Now you need to check in every place whether the corresponding power-supply is registered or not which makes the code uglier and more prone to errors.
| |