Messages in this thread | | | Date | Thu, 19 Apr 2012 11:51:16 +0530 | From | Amit Shah <> | Subject | Re: [RFC PATCH] virtio_console: link vq to port with a private pointer in struct virtqueue |
| |
On (Wed) 18 Apr 2012 [15:33:33], Paolo Bonzini wrote: > For virtio-scsi multiqueue support I would like to have an easy and > fast way to go from a virtqueue to the internal struct for that > queue. > > It turns out that virtio-serial has the same need, but it gets > by with a simple list walk. > > This patch adds a pointer to struct virtqueue that is reserved for > the virtio device, and uses it in virtio-serial. > > Cc: Amit Shah <amit.shah@redhat.com> > Cc: Rusty Russell <rusty@rustcorp.com.au> > Cc: "Michael S. Tsirkin" <mst@redhat.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > Untested; what do you think? Would this patch be acceptable > as is, or only with a more pressing need in virtio-scsi, or never?
Yes, this is useful. Saves taking a spin lock and walking the list each time any data is received from the host.
Acked-by: Amit Shah <amit.shah@redhat.com>
Thanks,
Amit
| |