lkml.org 
[lkml]   [2012]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] spi/ep93xx: clean probe/remove routines
On Wed, Apr 18, 2012 at 11:09:18AM -0500, H Hartley Sweeten wrote:
> But, I really don't think we actually gain anything by displaying the
> memory and irq. Maybe this would be more useful:
>
> dev_info(&pdev->dev, "EP93xx SPI Controller using %s\n",
> espi->dma_tx ? "DMA" : "PIO");
>
> That way the user knows at boot time if the spi controller is using DMA or PIO.
>
> Mika, what do you think?

I agree, having the driver to print whether DMA or PIO is used brings more
value than it is currently doing. However, that is a subject of a separate
patch not this one.


\
 
 \ /
  Last update: 2012-04-19 08:23    [W:0.546 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site