Messages in this thread | | | Date | Thu, 19 Apr 2012 18:32:12 +0200 | From | Roland Stigge <> | Subject | Re: [PATCH v4] i2c: Add device tree support to i2c-pnx.c |
| |
Hi,
On 04/19/2012 06:07 PM, Wolfram Sang wrote: >> + - clock-frequency: desired I2C bus clock frequency in Hz, >> Default: 100000 Hz + - pnx,timeout: I2C bus timeout in >> milliseconds, Default: 10 ms > > I'd like to repeat my question to the devicetree folks here: Can we > have timeout generic? It doesn't make sense to me to have that per > vendor again and again.
Sounds completely reasonable.
To help make the devicetree conversion into 3.5, I would prefer to integrate the "vendor,timeout" as-is if a longish standardization process would block this, considering that we luckily only have 2-3 of such timeout definitions currently.
I'd volunteer to clean up later by preparing a patch when there is a standard timeout defined.
If we have a solution soon, I will prepare a new version of the patch, of course, in the next days.
>> + i2c2: i2c@400a8000 { + compatible = "nxp,pnx-i2c"; + reg = >> <0x400a8000 0x100>; + interrupt-parent = <&mic>; + interrupts = >> <50 0>; + #address-cells = <1>; + #size-cells = <0>; + >> clock-frequency = <0x186a0>; + pnx,timeout = <0x64>; > > Did you change this, too? Timeouts are better readable in dec :)
Right. But even when removing the "0x" in the timeout line above, it's still hex, see Documentation/devicetree/booting-without-of.txt
Or did I get sth. wrong?
Thanks,
Roland
| |