Messages in this thread | | | Date | Thu, 19 Apr 2012 09:23:49 -0600 | From | Stephen Warren <> | Subject | Re: [PATCHv2 1/2] drivers: input: keypad: Add device tree support |
| |
On 04/19/2012 09:15 AM, Sourav Poddar wrote: > Update the Documentation with omap4 keypad device tree > binding information. > Add device tree support for omap4 keypad driver. > > Tested on omap4430 sdp with 3.4-rc3.
> diff --git a/Documentation/devicetree/bindings/input/omap-keypad.txt b/Documentation/devicetree/bindings/input/omap-keypad.txt
> +- Keys represented as child nodes: Each key connected to the keypad > + controller is represented as a child node to the keypad controller > + device node and should include the following properties. > + - keypad,row: the row number to which the key is connected. > + - keypad,column: the column number to which the key is connected. > + - linux,code: the key-code to be reported when the key is pressed > + and released.
Shouldn't this use the common matrix keymap bindings; Documentation/devicetree/bindings/input/matrix-keymap.txt
| |