lkml.org 
[lkml]   [2012]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] [media] ite-cir: postpone ISR registration
On Wed, Apr 18, 2012 at 09:54:07PM +0100, Luis Henriques wrote:
> An early registration of an ISR was causing a crash to several users (for
> example here: http://bugs.launchpad.net/bugs/972723 The reason was that
> IRQs were being triggered before the driver initialisation was completed.
>
> This patch fixes this by moving the invocation to request_irq() to a later
> stage on the driver probe function.
>
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> ---
> drivers/media/rc/ite-cir.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c
> index 682009d..98d8ccf 100644
> --- a/drivers/media/rc/ite-cir.c
> +++ b/drivers/media/rc/ite-cir.c
> @@ -1521,10 +1521,6 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id
> dev_desc->io_region_size, ITE_DRIVER_NAME))
> goto failure;
>
> - if (request_irq(itdev->cir_irq, ite_cir_isr, IRQF_SHARED,
> - ITE_DRIVER_NAME, (void *)itdev))
> - goto failure;
> -
> /* set driver data into the pnp device */
> pnp_set_drvdata(pdev, itdev);
> itdev->pdev = pdev;
> @@ -1600,6 +1596,10 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id
> rdev->driver_name = ITE_DRIVER_NAME;
> rdev->map_name = RC_MAP_RC6_MCE;
>
> + if (request_irq(itdev->cir_irq, ite_cir_isr, IRQF_SHARED,
> + ITE_DRIVER_NAME, (void *)itdev))
> + goto failure;
> +
> ret = rc_register_device(rdev);
> if (ret)
> goto failure;
> --
> 1.7.9.5

I completely forgot to add:

Cc: <stable@vger.kernel.org>

to my email.

Cheers,
--
Luis


\
 
 \ /
  Last update: 2012-04-19 17:11    [W:0.072 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site