Messages in this thread | | | Date | Thu, 19 Apr 2012 17:00:43 +0400 | From | Konstantin Khlebnikov <> | Subject | Re: [PATCH linux-next] ipc: fix local variable initialization in compat_do_msg_fill() |
| |
Konstantin Khlebnikov wrote: > The "msgp" must points to the userspace buffer. > > fix for linux-next commit 774d0252d303969a7281eefd6eaccde50bb6eb6e > ("c/r: ipc: message queue receive cleanup")
Oops, Dan Carpenter had caught this several days before me: [patch] c/r: ipc: uninitialized variable in compat_do_msg_fill()
> > Signed-off-by: Konstantin Khlebnikov<khlebnikov@openvz.org> > Cc: Stanislav Kinsbursky<skinsbursky@parallels.com> > Cc: Lucas De Marchi<lucas.de.marchi@gmail.com> > Cc: Chris Metcalf<cmetcalf@tilera.com> > Cc: Cyrill Gorcunov<gorcunov@openvz.org> > Cc: Pavel Emelyanov<xemul@parallels.com> > Cc: Arnd Bergmann<arnd@arndb.de> > Cc: Andrew Morton<akpm@linux-foundation.org> > --- > ipc/compat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ipc/compat.c b/ipc/compat.c > index 6da376b..0c2ebd0 100644 > --- a/ipc/compat.c > +++ b/ipc/compat.c > @@ -363,7 +363,7 @@ static long compat_do_msg_steal(void __user *dest, struct msg_msg *msg, size_t b > > long compat_do_msg_fill(void __user *dest, struct msg_msg *msg, size_t bufsz) > { > - struct compat_msgbuf __user *msgp; > + struct compat_msgbuf __user *msgp = dest; > size_t msgsz; > > if (put_user(msg->m_type,&msgp->mtype)) >
| |