Messages in this thread | | | Date | Thu, 19 Apr 2012 14:18:24 +0300 | Subject | Re: [PATCH] smb347_charger: Cleanup power supply registration code in probe | From | Mika Westerberg <> |
| |
On Thu, Apr 19, 2012 at 2:10 PM, Pallala, Ramakrishna <ramakrishna.pallala@intel.com> wrote: >> Sent: Thursday, April 19, 2012 12:41 PM >> To: Pallala, Ramakrishna >> Cc: linux-kernel@vger.kernel.org; Anton Vorontsov; Anton Vorontsov >> Subject: Re: [PATCH] smb347_charger: Cleanup power supply registration code in probe >> >> On Fri, Apr 13, 2012 at 03:14:52PM +0530, Ramakrishna Pallala wrote: >> > This patch checks if the usb or mains charging is enabled by the >> > platform before registering with the power supply class. >> >> Can you describe why this change is needed? The current code always registers all the >> power-supplies but if we haven't enabled for example USB charging, then the online >> property for USB ps is set to 0. > > If we haven't enabled USB charging then why to waste kernel resources? > What we will gain by registering with power supply class if USB charging is not enabled?
For one we have a consistent interface to userspace regardless of how the platform has configured the driver. For example if USB charging is not enabled userspace can still see the 'smb347-usb' directory but 'online' attribute is always set to zero.
| |