lkml.org 
[lkml]   [2012]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 04/37] atl1c: remove VPD register
    Date
    Ok, I will update it. thanks a lot

    -Xiong
    ________________________________________
    发件人: Ben Hutchings [bhutchings@solarflare.com]
    发送时间: 2012年4月14日 22:22
    收件人: Huang, Xiong
    Cc: David Miller; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; qca-linux-team; nic-devel
    主题: RE: [PATCH 04/37] atl1c: remove VPD register

    On Sat, 2012-04-14 at 09:12 +0000, Huang, Xiong wrote:
    >
    > > -----Original Message-----
    > > From: David Miller [mailto:davem@davemloft.net]
    > > Sent: Saturday, April 14, 2012 8:46
    > > To: Huang, Xiong
    > > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; qca-linux-team; nic-
    > > devel
    > > Subject: Re: [PATCH 04/37] atl1c: remove VPD register
    > >
    > > From: xiong <xiong@qca.qualcomm.com>
    > > Date: Fri, 13 Apr 2012 08:14:29 +0800
    > >
    > > > VPD register is only used for L1(devid=PCI_DEVICE_ID_ATTANSIC_L1) to
    > > > access external NV-memory.
    > > > l1c & later chip doesn't use it any more.
    > > >
    > > > Signed-off-by: xiong <xiong@qca.qualcomm.com>
    > > > Tested-by: Liu David <dwliu@qca.qualcomm.com>
    > >
    > > You just broke ethtool register dumps with this change.
    > >
    > > Now, all the initial registers are reported offset by one entry, yet the last two are
    > > still reported in their original spots.
    > >
    > > This layout is exposed to userspace, and interpreted by tools, and you cannot
    > > change it.
    > >
    > > If this register always reports some value, you should just keep it there in the
    > > dumps.
    > >
    > The VPD register doesn't report anything :(, just a dummy register now.
    > we don't have any special tools in userspace to explain the dumped registers.
    > Actually the purpose of dumping these registers via ethtool is just for debug.
    [...]

    Of course, the whole purpose of the operation is for debugging. But you
    should bump the dump version number (currently 0) every time you change
    the offsets of registers in the dump.

    Ben.

    --
    Ben Hutchings, Staff Engineer, Solarflare
    Not speaking for my employer; that's the marketing department's job.
    They asked us to note that Solarflare product names are trademarked.

    \
     
     \ /
      Last update: 2012-04-17 10:39    [W:3.682 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site