lkml.org 
[lkml]   [2012]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ethernet: fix checkpatch errors
From
From: Laura Vasilescu <laura@rosedu.org>
Date: Tue, 17 Apr 2012 17:27:24 +0300

> Signed-off-by: Laura Vasilescu <laura@rosedu.org>

I'd rather have the checkpath errors than what we end up with
your changes:

> - else if (1 /*dev->flags&IFF_PROMISC */ ) {
> - if (unlikely(compare_ether_addr_64bits(eth->h_dest, dev->dev_addr)))
> + else if (1 /*dev->flags&IFF_PROMISC */) {
> + if (unlikely(compare_ether_addr_64bits(eth->h_dest,
> + dev->dev_addr)))

This indentation is wrong, the "dev->dev_addr" argument must line up
with the first column after the openning parenthesis on the previous
line.

> -int eth_header_cache(const struct neighbour *neigh, struct hh_cache *hh, __be16 type)
> +int eth_header_cache(const struct neighbour *neigh,
> + struct hh_cache *hh,
> + __be16 type)

Same problem here for hh and type args.


\
 
 \ /
  Last update: 2012-04-18 22:37    [W:1.940 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site