Messages in this thread | | | Subject | Re: KGTP (Linux Kernel debugger and tracer) 20120406 release(hotcode analyzer hotcode.py can output html) include patch for review | From | Geoff Levand <> | Date | Tue, 17 Apr 2012 18:05:17 -0700 |
| |
Hi Hui,
On Sat, 2012-04-07 at 20:21 +0800, Hui Zhu wrote: > Signed-off-by: Hui Zhu <teawater@gmail.com>
You have done some interesting work, but can I recommend a few things?
Please break your patch into a few smaller ones, say, one that adds the core kgtp support, one that adds the documentation files, one that adds the scripts. Each patch should have a suitable comment that describes the changes. For kgtp the patch for the core support would of course have a discussion of the feature and its benefits, etc.
Also, please post your patches inline so we can give line-by-line comments. It is difficult to give comments when the patch is an email attachment.
-Geoff
| |