lkml.org 
[lkml]   [2012]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH v2] ASoC: da7210: Add support for PLL and SRM
On Tue, Apr 17, 2012 at 07:51:00PM +0530, Ashish Chavan wrote:
> On Tue, 2012-04-17 at 14:43 +0100, Mark Brown wrote:

> > I've applied but this would be a lot clearer if it were writen as a
> > single if statement with &&s.

> Actually I implemented it like that first. But then realized that
> because of the 80 chars limit and long conditions, readability was
> hampered. Let me submit a patch to convert it to single if, if that is
> preferred way of doing it.

Hrm? The major problem with multiple if statements is that it introduces
massive levels of indentation which are hard to parse.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-04-17 16:13    [W:0.034 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site