lkml.org 
[lkml]   [2012]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 1/3] USB: Add driver for NXP ISP1301 USB transceiver
Date
On Tuesday 17 April 2012, Roland Stigge wrote:
> +static int match(struct device *dev, void *data)
> +{
> + struct device_node *node = (struct device_node *)data;
> + return dev->of_node == node ? 1 : 0;
> +}

One small correction: you should probably check if the device
is actually bound to isp1301_driver:

return (dev->of_node == node) && (dev->driver == &isp1301_driver.driver);

Otherwise, the changes from last version look all good.

Arnd


\
 
 \ /
  Last update: 2012-04-17 15:43    [W:0.033 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site