Messages in this thread Patch in this message | | | Subject | [PATCH linux-next] mm/hugetlb: fix warning in alloc_huge_page/dequeue_huge_page_vma | From | Konstantin Khlebnikov <> | Date | Tue, 17 Apr 2012 16:28:19 +0400 |
| |
This patch fixes gcc warning (and bug?) introduced in linux-next commit cc9a6c877 ("cpuset: mm: reduce large amounts of memory barrier related damage v3")
Local variable "page" can be uninitialized if nodemask from vma policy does not intersects with nodemask from cpuset. Even if it wouldn't happens it's better to initialize this variable explicitly than to introduce kernel oops on weird corner case.
mm/hugetlb.c: In function ‘alloc_huge_page’: mm/hugetlb.c:1135:5: warning: ‘page’ may be used uninitialized in this function
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org> Cc: Mel Gorman <mgorman@suse.de> --- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 4314a88..dcf4a55 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -532,7 +532,7 @@ static struct page *dequeue_huge_page_vma(struct hstate *h, struct vm_area_struct *vma, unsigned long address, int avoid_reserve) { - struct page *page; + struct page *page = NULL; struct mempolicy *mpol; nodemask_t *nodemask; struct zonelist *zonelist; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |