lkml.org 
[lkml]   [2012]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: iio: light: isl29018: use regmap for register access

HI Jonathan,

Thanks for fast review.

On Tuesday 17 April 2012 05:03 PM, Jonathan Cameron wrote:
> On 4/17/2012 9:50 AM, Laxman Dewangan wrote:
>> Using regmap for accessing register through i2c bus. This will
>> remove the code for caching registers, read-modify-write logics.
>> Also it will provide the debugfs feature to dump register
>> through regmap debugfs.
> I'd prefer the intial tab fixup for the kconfig file as a separate
> patch, but other than that
> all looks good.
>

Yes, this make sense. I will create fist patch for fixing this and then
next patch for actual my change.

> This will probably cause issues alongside the series I sent to Greg the
> other day though
> so you may want to sit on it for a day or two and rebase.

I will wait for your change to be in linux-next and then I will create
next patches.

>> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
> Acked-by: Jonathan Cameron<jic23@kernel.org>
>> ---
>> drivers/staging/iio/light/Kconfig | 19 ++--
>> drivers/staging/iio/light/isl29018.c | 176 +++++++++++++++++-----------------
>> 2 files changed, 99 insertions(+), 96 deletions(-)
>>
>> diff --git a/drivers/staging/iio/light/Kconfig b/drivers/staging/iio/light/Kconfig
>> index 53b49f7..fd39f72 100644
>> --- a/drivers/staging/iio/light/Kconfig
>> +++ b/drivers/staging/iio/light/Kconfig
>> @@ -4,15 +4,16 @@
>> menu "Light sensors"
>>
>> config SENSORS_ISL29018
>> - tristate "ISL 29018 light and proximity sensor"
>> - depends on I2C
>> - default n
>> - help
>> - If you say yes here you get support for ambient light sensing and
>> - proximity infrared sensing from Intersil ISL29018.
>> - This driver will provide the measurements of ambient light intensity
>> - in lux, proximity infrared sensing and normal infrared sensing.
>> - Data from sensor is accessible via sysfs.
>> + tristate "ISL 29018 light and proximity sensor"
>> + depends on I2C
>> + select REGMAP_I2C
>> + default n
>> + help
>> + If you say yes here you get support for ambient light sensing and
>> + proximity infrared sensing from Intersil ISL29018.
>> + This driver will provide the measurements of ambient light intensity
>> + in lux, proximity infrared sensing and normal infrared sensing.
>> + Data from sensor is accessible via sysfs.
> Down to here is a valid but unconnected change. Can you break this out
> to a separate patch?

Sure, I will do.


\
 
 \ /
  Last update: 2012-04-17 14:01    [W:0.086 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site