Messages in this thread | | | Date | Mon, 16 Apr 2012 11:52:07 -0400 | From | Vivek Goyal <> | Subject | Re: [Lsf] [RFC] writeback and cgroup |
| |
On Mon, Apr 16, 2012 at 09:07:07PM +0800, Fengguang Wu wrote:
[..] > Vivek, I noticed these lines in cfq code > > sscanf(dev_name(bdi->dev), "%u:%u", &major, &minor); > > Why not use bdi->dev->devt? The problem is that dev_name() will > return "btrfs-X" for btrfs rather than "major:minor".
Isn't bdi->dev->devt 0? I see following code.
add_disk() bdi_register_dev() bdi_register() device_create_vargs(MKDEV(0,0)) dev->devt = devt = MKDEV(0,0);
So for normal block devices, I think bdi->dev->devt will be zero, that's why probably we don't use it.
Thanks Vivek
| |