Messages in this thread | | | Date | Mon, 16 Apr 2012 17:37:08 +0200 | From | Samuel Ortiz <> | Subject | Re: [PATCH] mfd: Silence uninitialized variable warning for wm8994-core |
| |
Hi Axel,
On Thu, Apr 05, 2012 at 11:49:12AM +0800, Axel Lin wrote: > Fix below build warning: > CC drivers/mfd/wm8994-core.o > drivers/mfd/wm8994-core.c: In function 'wm8994_i2c_probe': > drivers/mfd/wm8994-core.c:582:7: warning: 'patch_regs' may be used uninitialized in this function [-Wuninitialized] > drivers/mfd/wm8994-core.c:393:14: note: 'patch_regs' was declared here > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > --- > drivers/mfd/wm8994-core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c > index 9d7ca1e..bd02202 100644 > --- a/drivers/mfd/wm8994-core.c > +++ b/drivers/mfd/wm8994-core.c > @@ -390,7 +390,7 @@ static __devinit int wm8994_device_init(struct wm8994 *wm8994, int irq) > struct regmap_config *regmap_config; > const struct reg_default *regmap_patch = NULL; > const char *devname; > - int ret, i, patch_regs; > + int ret, i, patch_regs = 0; I'd agree with Mark here. I don't particularily like this kind of fix as it basically turns potentially useful gcc warnings off.
Cheers, Samuel.
-- Intel Open Source Technology Centre http://oss.intel.com/
| |