Messages in this thread | | | Date | Sun, 15 Apr 2012 10:34:45 +0300 | From | Or Gerlitz <> | Subject | Re: [PATCH] IB: mlx4: Fix mem leaks in ib_link_query_port() |
| |
On 4/12/2012 12:43 AM, Jesper Juhl wrote: > If, in ib_link_query_port(), the call to mlx4_MAD_IFC() fails we will > currently do 'return err;' which will leak 'in_mad' and 'out_mad' that > we previously allocated. I believe we should instead do 'goto out;' > where we'll properly free the memory we previously allocated.
Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
Roland, could you push that?
Or.
| |