Messages in this thread | | | Date | Mon, 16 Apr 2012 11:36:25 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH v2 07/16] KVM: MMU: introduce for_each_pte_list_spte |
| |
On 04/14/2012 10:44 AM, Takuya Yoshikawa wrote:
> On Fri, 13 Apr 2012 18:12:41 +0800b > Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> wrote: > >> It is used to walk all the sptes of the specified pte_list, after >> this, the code of pte_list_walk can be removed >> >> And it can restart the walking automatically if the spte is zapped > > Well, I want to ask two questions: > > - why do you prefer pte_list_* naming to rmap_*? > (not a big issue but just curious)
pte_list is a common infrastructure for both parent-list and rmap.
> - Are you sure the whole indirection by this patch will > not introduce any regression? > (not restricted to get_dirty) >
I tested it with kernbench, no regression is found.
It is not a problem since the iter and spte should be in the cache.
| |