Messages in this thread | | | Subject | Re: [PATCH RESEND] LEDS-One-Shot-Timer-Trigger-implementation | From | Shuah Khan <> | Date | Sun, 15 Apr 2012 10:35:52 -0600 |
| |
> Having looked at the code and read through the thread and Andrew's patch > review, I'm left wondering why you didn't add a new trigger for this > functionality? > > The reason I ask that there do seem to be a number of questions about > backwards compatibility and this also seems to complicate the standard > timer trigger in non-obvious ways. Having a new trigger for this > functionality would allow for a much clearer namespace and no backwards > compatibility issues. It also means additional functionality can be > added later in a contained place. I'm wondering if there is a downside > to a separate trigger I'm missing?
I finally :) understand your question about why I didn't add a new trigger. I don't see any reason why I should a new trigger should not be added and it does make it clean without no backwards compatibility issues. I will get working on that and get back to you.
Thanks, -- Shuah
| |