Messages in this thread | | | Date | Sun, 15 Apr 2012 12:33:06 -0400 (EDT) | Subject | Re: [PATCH net-next] net: vxge: Add MODULE_FIRMWARE | From | David Miller <> |
| |
From: Ben Hutchings <ben@decadent.org.uk> Date: Sun, 15 Apr 2012 14:56:55 +0100
> Also: this driver's behaviour of automatically updating flash without > any confirmation seems quite dangerous. The driver also isn't usable > after it performs such an update: > > printk(KERN_NOTICE "Upgrade of firmware successful! Adapter must be " > "hard reset before using, thus requiring a system reboot or a " > "hotplug event.\n"); > > So what is the point of integrating firmware update into the driver at > all?
This is beyond terrible.
| |