Messages in this thread | | | Date | Fri, 13 Apr 2012 09:32:26 -0400 | From | Vivek Goyal <> | Subject | Re: [PATCH 1/8] blkcg: kill blkio_list and replace blkio_list_lock with a mutex |
| |
On Thu, Apr 12, 2012 at 04:29:33PM -0700, Tejun Heo wrote:
Hi Tejun,
> @@ -732,20 +732,21 @@ void blkio_policy_register(struct blkio_policy_type *blkiop) > { > struct request_queue *q; > > + mutex_lock(&blkcg_pol_mutex); > + > blkcg_bypass_start(); > - spin_lock(&blkio_list_lock); > > BUG_ON(blkio_policy[blkiop->plid]);
A minor nit. It might be a good idea to check that blkiop->plid is not greater than BLKIO_NR_POLICIES for both registration and unresitration functions to avoid touching memory beyond blkio_policy[] array.
Thanks Vivek
| |