lkml.org 
[lkml]   [2012]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rtc: tegra: cleanup probe/remove routines
On 13/04/12 11:05 +0530, Venu Byravarasu wrote:
> > + if (info->tegra_rtc_irq <= 0)
> > + return -EBUSY;
> Interrupt support is needed only for wake up or timer support.
> Apart from them RTC can be used for reference time keeping.
>
> So, is it not good to print a warn message as "wake up
> with alarm is not supported" and proceed further instead of
> returning failure from the driver itself?

I propose that this patch would go in as is, as this is mainly for adjusting
probe/remove routines for using devm_* funcs, and to leave that above issue
you mentioned to another patch, as it would be a change to current behavior.


br,
Hannu



\
 
 \ /
  Last update: 2012-04-13 14:57    [W:0.051 / U:1.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site