Messages in this thread | | | Date | Thu, 12 Apr 2012 09:46:46 +0200 | From | Michal Simek <> | Subject | Re: [PATCH resend] microblaze: Do not select GENERIC_GPIO by default |
| |
On 04/10/2012 02:51 PM, Lars-Peter Clausen wrote: > On 04/10/2012 02:37 PM, Michal Simek wrote: >> Hi Lars, >> >> 2012/4/9 Lars-Peter Clausen<lars@metafoo.de<mailto:lars@metafoo.de>> >> >> The microblaze architecture does not provide a native GPIO API >> implementation >> nor requires GPIOLIB, but still selects GENERIC_GPIO by default. As a >> result the >> following build error occurs, if GPIOLIB is not selected: >> >> include/asm-generic/gpio.h: In function 'gpio_get_value_cansleep': >> include/asm-generic/gpio.h:218: error: implicit declaration of >> function '__gpio_get_value' >> include/asm-generic/gpio.h: In function 'gpio_set_value_cansleep': >> include/asm-generic/gpio.h:224: error: implicit declaration of >> function '__gpio_set_value' >> >> This patch addresses the issue by not selecting GENERIC_GPIO by default. >> This >> causes the GPIO API to be stubbed out if no implementation is provided. >> >> Signed-off-by: Lars-Peter Clausen<lars@metafoo.de<mailto:lars@metafoo.de>> >> Cc: stable@vger.kernel.org<mailto:stable@vger.kernel.org> >> --- >> arch/microblaze/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> Sorry for taking so long. Can you please send me your .config file. I have >> never seen that Microblaze has any problem with it. >> > > Hi, > > basically any config which has CONFIG_GPIOLIB not set. I've attached my config.
Will add it to mainline.
Tested-by: Michal Simek <monstr@monstr.eu>
Thanks, Michal
-- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian
| |