Messages in this thread | | | Date | Fri, 13 Apr 2012 01:54:46 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/2] mm: set task exit code before complete_vfork_done() |
| |
On 04/12, Konstantin Khlebnikov wrote: > > kthread_stop() uses task->vfork_done for synchronization. The exiting kthread > shouldn't do complete_vfork_done() until it sets ->exit_code. > > fix for mm-correctly-synchronize-rss-counters-at-exit-exec.patch
Yes, this should fix the problem with kthread_stop()...
Damn, Konstantin I have to admit, I'll try to find another technical reason against mm-correctly-synchronize-rss-counters-at-exit-exec.patch even with this fix ;)
Most probably I am wrong, but it looks overcomplicated. Somehow I dislike irrationally the fact you moved mm_release() from exit_mm().
But, once again, it is not that I see the better solution.
2/2 looks fine at first glance... and afaics it is "off-topic".
Oleg.
| |