Messages in this thread | | | Date | Thu, 12 Apr 2012 16:05:07 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c |
| |
On 04/03/2012 07:56 AM, Sergei Shtylyov wrote: > Hello. > > On 03-04-2012 14:12, Thang Q. Nguyen wrote: > >> Signed-off-by: Thang Q. Nguyen<tqnguyen@apm.com> >> --- >> Changes for v2: >> - Use git rename feature to change the driver to the newname and for >> easier review. > >> arch/powerpc/boot/dts/bluestone.dts | 21 + >> drivers/ata/Makefile | 2 +- >> drivers/ata/{sata_dwc_460ex.c => sata_dwc_4xx.c} | 1371 >> ++++++++++++++-------- >> 3 files changed, 904 insertions(+), 490 deletions(-) >> rename drivers/ata/{sata_dwc_460ex.c => sata_dwc_4xx.c} (56%) > > You submitted a magapatch doing several things at once (some even > needlessly) and even in two areas of the kernel. This needs proper > splitting/description.
Agreed...
| |