Messages in this thread | | | Subject | Re: [PATCH] staging: vt6656: Don't leak memory in drivers/staging/vt6656/ioctl.c::private_ioctl() | From | Xi Wang <> | Date | Wed, 11 Apr 2012 18:46:33 -0400 |
| |
On Apr 11, 2012, at 6:35 PM, Jesper Juhl wrote:
> - pNodeList = (PSNodeList)kmalloc(sizeof(SNodeList) + (sNodeList.uItem * sizeof(SNodeItem)), (int)GFP_ATOMIC); > + pNodeList = kmalloc(sizeof(SNodeList) + (sNodeList.uItem * sizeof(SNodeItem)), (int)GFP_ATOMIC);
Can you also remove casts like "(int)GFP_ATOMIC"?
The parentheses "(sNodeList.uItem * sizeof(SNodeItem))" are also pointless..
- xi
| |