lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] creds: kill __task_cred()->task_is_dead() validation
On 04/11, Eric W. Biederman wrote:
>
> Oleg Nesterov <oleg@redhat.com> writes:
>
> A small nit. The subject should be:
> "Remove task_is_dead from __task_cred() validation."
> there is no method __task_cred()->task_is_dead().

I often use this notation to show the caller and the callee,
but I don't really mind.

> > Unfortunately, we can't kill task_is_dead() right now, it has already
> > found the bugy users in drivers/staging/, the fix already exists.
>
> I would say task_is_dead() has already acquired buggy users in
> drivers/staging.

Argh, it least I shouldn't have said "bugy".

> As for the patch itself, and the direction of removing task_is_dead().
> It looks good from where I sit.
>
> Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>

Thanks! I'll fix the subject/changelog and resend with your and
David's acks.

Oleg.



\
 
 \ /
  Last update: 2012-04-11 20:55    [W:0.054 / U:0.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site