lkml.org 
[lkml]   [2012]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3.3.0] kernel:kfifo: export __kfifo_max_r symbol.
From
Date
Locks okay to me.

Acked-by: Stefani Seibold <stefani@seibold.net>

Am Mittwoch, den 11.04.2012, 09:01 +0100 schrieb Srinivas KANDAGATLA:
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> kfifo_avail expands to __kfifo_max_r which is not an exported symbol.
> Any kernel module using kfifo_avail will result in build failures
> because of this.
> This patch just exports __kfifo_max_r symbol to fix such problems in
> future.
>
> This bug was orignially reported by Stephen Rothwell <sfr@canb.auug.org.au>
> during v4l-dvb tree integration into linux-next.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> ---
> Hi All,
> A bulid failure during v4l-dvb tree integration into linux-next shows that __kfifo_max_r symbol is not exported.
> All the __kifo_* functions declared in kfifo.h are already exported symbols.
> I see no reason why __kfifo_max_r should not be exported too.
>
> comments?
>
> --srini
>
> kernel/kfifo.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/kfifo.c b/kernel/kfifo.c
> index c744b88..59dcf5b 100644
> --- a/kernel/kfifo.c
> +++ b/kernel/kfifo.c
> @@ -402,6 +402,7 @@ unsigned int __kfifo_max_r(unsigned int len, size_t recsize)
> return max;
> return len;
> }
> +EXPORT_SYMBOL(__kfifo_max_r);
>
> #define __KFIFO_PEEK(data, out, mask) \
> ((data)[(out) & (mask)])




\
 
 \ /
  Last update: 2012-04-11 19:09    [W:0.165 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site