Messages in this thread | | | Date | Tue, 10 Apr 2012 22:58:49 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 1/4] tools: Add Makefile.include |
| |
On Tue, Apr 10, 2012 at 10:27:21PM +0200, Sam Ravnborg wrote: > Hi Borislav. > > Some random comments as I really did not look at this > part of the patch-set before.
.. and I appreciate those, thanks.
> > +# > > +# Include saner warnings here, which can catch bugs: > > +# > > +EXTRA_WARNINGS := -Wformat > > +EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wformat-security > > Two general comments - and I know this is just something you copied...
Yep, I did from perf's Makefile.
> Why not use the += operator. The below looks like shell script syntax. > And we use the += operator in other places - at least in the kernel stuff.
Yep, this makes this assignment monster a bit more readable, sure.
> AND WHY ALL THESE SCREAMING CAPITAL LETTERS? > I know Makefiles and scripts are full of them - but that does not help > the readability. > > For kbuild I generally shifted to use: > - lower-case names for local stuff > - Upper case letters for global stuff - properly prefixed to avoid collisions > EXTRA_WARNINGS likely fall into the category global-stuff, > but then a local variable could still be usefull.
Well, my intention was to have EXTRA_WARNINGS be a global variable which all tools under tools/ could start using so that we can benefit from the compiler doing some more extensive checking. Thus all caps, no?
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |