Messages in this thread | | | Date | Tue, 10 Apr 2012 08:49:43 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH] virtio_blk: Add help function to format mass of disks |
| |
Hello, guys.
On Tue, Apr 10, 2012 at 04:34:06PM +0300, Michael S. Tsirkin wrote: > > Why not use 'base' below? neither unit nor base change. > > Yes it's a bit strange, it was the same in Tejun's patch. > Tejun, any idea?
It was years ago, so I don't recall much. I think I wanted to use a variable name which signifies its role - I worked out the rather convoluted base number logic on paper first and I probably wanted to keep the distinctions. I don't think it really matters at this point tho. Just make sure those functions are marked deprecated so that no one else copies them.
Thanks.
-- tejun
| |