Messages in this thread | | | Subject | Re: [PATCH] net: orphan queued skbs if device tx can stall | From | Eric Dumazet <> | Date | Tue, 10 Apr 2012 12:04:19 +0200 |
| |
On Tue, 2012-04-10 at 12:31 +0300, Michael S. Tsirkin wrote:
> True. Still this is the only interface we have for controlling > the internal queue length so it seems safe to assume someone > is using it for this purpose. >
So to workaround a problem in tun, you want to hack net/core/dev.c :(
Packets in qdisc should not be orphaned.
If you think about it, why do we attach skb to socket in the first place ?
If its not needed for tun, why should it be needed for other devices ?
If TUN has a problem being stopped forever, maybe it should take appropriate action to flush all packets in qdisc queue after a while, as this makes no sense to delay packets forever.
| |