Messages in this thread | | | Date | Sun, 1 Apr 2012 19:08:20 -0700 | Subject | Re: [PATCH 01/19 v2] avr32/mm/fault.c: Port OOM changes to do_page_fault | From | Håvard Skinnemoen <> |
| |
On Sat, Mar 31, 2012 at 4:58 AM, Kautuk Consul <consul.kautuk@gmail.com> wrote: > Commit d065bd810b6deb67d4897a14bfe21f8eb526ba99 > (mm: retry page fault when blocking on disk transfer) and > commit 37b23e0525d393d48a7d59f870b3bc061a30ccdb > (x86,mm: make pagefault killable) > > The above commits introduced changes into the x86 pagefault handler > for making the page fault handler retryable as well as killable. > > These changes reduce the mmap_sem hold time, which is crucial > during OOM killer invocation. > > Port these changes to AVR32. > > Signed-off-by: Mohd. Faris <mohdfarisq2010@gmail.com> > Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
Looks very good, thanks.
> @@ -122,6 +124,7 @@ good_area: > if (!(vma->vm_flags & VM_WRITE)) > goto bad_area; > writeaccess = 1; > + flags |= FAULT_FLAG_WRITE;
Could you remove the 'writeaccess' variable as well? It looks unused after applying your patch.
Ug...the avr32 arch is in a terrible state. Someone appears to have removed the atmel_nand driver...
Havard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |