Messages in this thread | | | From | Rabin Vincent <> | Date | Mon, 2 Apr 2012 01:09:27 +0530 | Subject | Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support |
| |
On Mon, Apr 2, 2012 at 00:52, Linus Walleij <linus.walleij@linaro.org> wrote: > On Sun, Apr 1, 2012 at 8:58 PM, Mark Brown > <broonie@opensource.wolfsonmicro.com> wrote: > >> diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c >> index ebc1e86..5be3248 100644 >> --- a/drivers/mfd/db8500-prcmu.c >> +++ b/drivers/mfd/db8500-prcmu.c >> @@ -2788,6 +2788,7 @@ static struct regulator_init_data db8500_regulators[DB8500_NUM_REGULATORS] = { >> .constraints = { >> .name = "db8500-vape", >> .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> + .always_on = true, >> }, >> .consumer_supplies = db8500_vape_consumers, >> .num_consumer_supplies = ARRAY_SIZE(db8500_vape_consumers), > > Combined with the PL022 patch this causes a power regression since > the PL022 is hereafter always on.
How can there be a "power regression" here? This is the only user of the vcore regulator, and, apart from the fact that its disable routine only decrements an essentialy write-only variable, it is shared which several devices which already never disable it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |