Messages in this thread | | | From | Rabin Vincent <> | Date | Mon, 2 Apr 2012 01:02:36 +0530 | Subject | Re: [PATCH/RFC] ARM: amba: Remove AMBA level regulator support |
| |
On Sun, Apr 1, 2012 at 22:52, Linus Walleij <linus.walleij@linaro.org> wrote: > On Sun, Apr 1, 2012 at 5:29 PM, Mark Brown > <broonie@opensource.wolfsonmicro.com> wrote: >> The impact should be minimal since currently there are no mainline >> systems which actually provide a vcore regulator so none need updating. > > Oh yes there are: > drivers/mfd/db8500-prcmu.c > > This driver registers a number of voltage domain regulators, > among those: > > static struct regulator_consumer_supply db8500_vape_consumers[] = { > (...) > REGULATOR_SUPPLY("vcore", "sdi0"), > REGULATOR_SUPPLY("vcore", "sdi1"), > REGULATOR_SUPPLY("vcore", "sdi2"), > REGULATOR_SUPPLY("vcore", "sdi3"), > REGULATOR_SUPPLY("vcore", "sdi4"), > (...) > REGULATOR_SUPPLY("vcore", "uart0"), > REGULATOR_SUPPLY("vcore", "uart1"), > REGULATOR_SUPPLY("vcore", "uart2"), > > IIRC the machine will not boot (i.e. these drivers cannot even > probe) without these regulators in place, so they get enabled by > the AMBA bus code.
These vcore "regulators" do nothing but increment a variable which is write-only in mainline, so the machine will boot and drivers will probe fine with Mark's patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |