Messages in this thread | | | Subject | Re: [PATCH 02/03] HWMON: HWMON driver for DA9052/53 PMIC v3 | From | Guenter Roeck <> | Date | Wed, 7 Mar 2012 11:08:22 -0800 |
| |
On Fri, 2012-03-02 at 09:29 -0500, Ashish Jangam wrote: > The DA9052 PMIC provides an Analogue to Digital Converter with 10 bits > resolution and 10 channels. > > This patch monitors the DA9052 PMIC's ADC channels mostly for battery > parameters like battery temperature, junction temperature, battery > current etc. > > This patch is functionally tested on Samsung SMDKV6410 > > Signed-off-by: David Dajun Chen <dchen@diasemi.com> > Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>
Only comment I would have is that it might make sense to use DIV_ROUND_CLOSEST(). That is a minor issue, though, so feel free to add
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
Question is where this is going. I can not add it to hwmon-next without the matching mfd changes. Any idea ?
Thanks, Guenter
| |